Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make commit type detection algorithm more reliable #33

Open
le-git-imate opened this issue Aug 20, 2019 · 0 comments
Open

Make commit type detection algorithm more reliable #33

le-git-imate opened this issue Aug 20, 2019 · 0 comments
Labels
enhancement Ask to enhance an existing feature extra attention Extra attention is needed

Comments

@le-git-imate
Copy link
Owner

le-git-imate commented Aug 20, 2019

Description of issue or feature request
Looking into the URL, le-git-imate can detect the commit type since the URL corresponding to each commit has a unique pattern. More details is described here. However, the upload operation on GitLab is an exception as the URL does not have a specific pattern. We should make sure that the current approach to detect upload operation on GitHub is fully reliable.
This issue may be resolved along with #8.

Current behavior

  • The current approach to detect upload operation on GitHub is not fully reliable.

Expected behavior

  • Make sure that le-git-imate detects commit types correctly (in particular the upload operation on GitLab).
  • Add unit tests.
@le-git-imate le-git-imate added enhancement Ask to enhance an existing feature extra attention Extra attention is needed labels Aug 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Ask to enhance an existing feature extra attention Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant