Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if the commit signature extraction is always reliable #31

Open
le-git-imate opened this issue Aug 20, 2019 · 0 comments
Open

Check if the commit signature extraction is always reliable #31

le-git-imate opened this issue Aug 20, 2019 · 0 comments
Labels
extra attention Extra attention is needed

Comments

@le-git-imate
Copy link
Owner

le-git-imate commented Aug 20, 2019

Description of issue or feature request
To create a signed commit, the signature is computed over the commit fields. Then it is extracted from the commit by using a specific string pattern. Next the commit and its signature form a signed Git commit which will be used to create a signed Git commit object.
We need to make sure that the signature extraction always works.
This issue could be resolved in accordance with #3.

Current behavior

  • le-git-imate uses a very basic approach to extract the commit signature which may fail in some corner cases (if there is any!).

Expected behavior

  • Add unit tests to make sure commit signature extraction function works correctly.
@le-git-imate le-git-imate added the extra attention Extra attention is needed label Aug 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
extra attention Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant