Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support merging branches with a large number of commits #30

Open
le-git-imate opened this issue Aug 20, 2019 · 0 comments
Open

Support merging branches with a large number of commits #30

le-git-imate opened this issue Aug 20, 2019 · 0 comments
Labels
feature New feature is requested

Comments

@le-git-imate
Copy link
Owner

le-git-imate commented Aug 20, 2019

Description of issue or feature request
One of the very first step in a merge commit is to compare the PR and master branch to determine the changes (i.e., added/deleted/modified files). le-git-imate uses different APIs to make the comparison on GitHub and GitLab.
However, those API may fail to function correctly if the number of commits in the PR exceeds a limit. On GitHub you can use the CompareBranch API to compare up to 250 commits. And if the number of changed files in a PR goes over 300, we can't simply use one API to list the files.
On GitLab, a diff API between two branches/commits may completely collapse if:

  • 50,000 lines have already been rendered.
  • 1000 files have already been rendered.

This issue could be address with #11.

Current behavior

  • le-git-imate does not support merging large PRs

Expected behavior

  • Support large merge commits which needs to
    -- first know all limitations we have when we use GitHub API to compare branches.
    -- second use alternative solutions like what is suggested by GitHub.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature is requested
Projects
None yet
Development

No branches or pull requests

1 participant