From f1aad4c6abde06bc8f1ac5fe59f631f8707a2a04 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C5=81ukasz=20Dziedziul?= Date: Thu, 7 Sep 2023 10:01:48 +0200 Subject: [PATCH] Don't set SO_REUSEPORT on Windows (#23947) [5.3.z] --- .../tpcengine/nio/NioAsyncServerSocketOptions.java | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/hazelcast-tpc-engine/src/main/java/com/hazelcast/internal/tpcengine/nio/NioAsyncServerSocketOptions.java b/hazelcast-tpc-engine/src/main/java/com/hazelcast/internal/tpcengine/nio/NioAsyncServerSocketOptions.java index df82340d5ba2d..017b5d7bc1cb8 100644 --- a/hazelcast-tpc-engine/src/main/java/com/hazelcast/internal/tpcengine/nio/NioAsyncServerSocketOptions.java +++ b/hazelcast-tpc-engine/src/main/java/com/hazelcast/internal/tpcengine/nio/NioAsyncServerSocketOptions.java @@ -18,12 +18,14 @@ import com.hazelcast.internal.tpcengine.net.AsyncSocketOptions; import com.hazelcast.internal.tpcengine.Option; +import com.hazelcast.internal.tpcengine.util.OS; import java.io.IOException; import java.io.UncheckedIOException; import java.net.SocketOption; import java.net.StandardSocketOptions; import java.nio.channels.ServerSocketChannel; +import java.util.Set; import static com.hazelcast.internal.tpcengine.util.Preconditions.checkNotNull; import static com.hazelcast.internal.tpcengine.util.ReflectionUtil.findStaticFieldValue; @@ -36,6 +38,7 @@ public class NioAsyncServerSocketOptions implements AsyncSocketOptions { // This option is available since Java 9, so we need to use reflection. private static final SocketOption STD_SOCK_OPT_SO_REUSEPORT = findStaticFieldValue(StandardSocketOptions.class, "SO_REUSEPORT"); + private static final Set> WINDOWS_UNSUPPORTED_OPTIONS = Set.of(StandardSocketOptions.SO_REUSEPORT); private final ServerSocketChannel serverSocketChannel; @@ -64,7 +67,13 @@ public boolean isSupported(Option option) { } private boolean isSupported(SocketOption socketOption) { - return socketOption != null && serverSocketChannel.supportedOptions().contains(socketOption); + if (socketOption == null) { + return false; + } + if (OS.isWindows() && WINDOWS_UNSUPPORTED_OPTIONS.contains(socketOption)) { + return false; + } + return serverSocketChannel.supportedOptions().contains(socketOption); } @Override