Prevent type conversions issues when parsing time-fractions #710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We received reports of users experiencing exceptions when parsing JWTs with timestamps with precision beyond microseconds on time-fractions. This guards against having any kind of edge-case when dealing with floats as input to the creation of DateTimeImmutable objects.
yassinrais
reviewed
Mar 23, 2021
There was a problem hiding this comment.
src/Token/Parser.php:118
* @param int|float|string $timestampAre you sur that its okey to put even string into param type ?
@param => accepted type in 'documentation'
Not accepting it is a BC-break with previously created tokens in v4. So, we have to support until v5 - that's also why I added a test to cover that. We can mark that as deprecated but it's not really a hill I'd die on. |
yassinrais
reviewed
Mar 23, 2021
There was a problem hiding this comment.
some bad news : https://3v4l.org/pTqmM 🤔 wait a minute nvm, i forgot the was u.u 😅 and number_format add .u format to integer
|
I dont have anything to add 💪 gj |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We received reports of users experiencing exceptions when parsing JWTs with timestamps with precision beyond microseconds on time-fractions.
This guards against having any kind of edge-case when dealing with floats as input to the creation of DateTimeImmutable objects.