Use the correct class name for in-memory keys in documentation #632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lcobucci
requested changes
Jan 28, 2021
There was a problem hiding this comment.
Thanks @lots0logs!
Just a small detail, we should also change this in v4.0.x branch (I'll apply the change and rebase things)
docs/configuration.md
Outdated
| @@ -81,9 +81,11 @@ use Lcobucci\JWT\Signer; | |||
| use Lcobucci\JWT\Signer\Key\LocalFileReference; | |||
| use Lcobucci\JWT\Signer\Key\InMemory; | |||
|
|
|||
| // You may use RSA OR ECDSA and all their variations (256, 384, and 512) and EdDSA over Curve25519 | |||
| $signer = new Signer\Rsa\Sha512(); | |||
| $signer = Signer\Ecdsa\Sha512::create(); | |||
There was a problem hiding this comment.
I think we should use an alert to convey this difference (instead of re-assigning the variable).
lcobucci
changed the title
lcobucci
approved these changes
Jan 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update configuration docs to match current code implementation.