Fix validation of the audience claim on the new API #562
+48
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lcobucci
reviewed
Nov 26, 2020
|
I'd suggest to use the |
lcobucci
force-pushed
the
audienceSingleElementArray
branch
from
c1581b2 to
bb84b25
Compare
On df9b734 we modified the type used to handle that claim, aiming to ensure compatibility with v4.0. However, we forgot to adjust the validation components.
lcobucci
force-pushed
the
audienceSingleElementArray
branch
from
bb84b25 to
a64bafd
Compare
lcobucci
changed the title
|
@b-water 🚢 Thanks for your help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #560 our jwt audience contains an array with a single element which breaks the validation