Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort by "Oldest first" in Following only returns max 3 months old claims, instead of the acutally oldest ones #7733

Open
keikari opened this issue Nov 14, 2022 · 2 comments
Labels
type: bug Existing functionality is wrong or broken

Comments

@keikari
Copy link
Contributor

keikari commented Nov 14, 2022

claim_search in Following page has release_time: ">3 months ago". Which makes sort by "oldest first" not return oldest claims.
Also when sorting by "newest first", can only find claims up to that time.

oldest-first

https://www.reddit.com/r/lbry/comments/yuewmm/lbry_desktop_client_sorting_by_oldest_first/

@keikari keikari added the type: bug Existing functionality is wrong or broken label Nov 14, 2022
@dgarrett01
Copy link

This can be fixed by commenting out or removing these if conditions in ui\component\claimListDiscover\view.jsx...

if (
(options.channel_ids && options.channel_ids.length > 20) ||
(options.any_tags && options.any_tags.length > 20)
) {
options.release_time = >${Math.floor(moment().subtract(3, CS.FRESH_MONTH).startOf('week').unix())};
} else if (
(options.channel_ids && options.channel_ids.length > 10) ||
(options.any_tags && options.any_tags.length > 10)
) {
options.release_time = >${Math.floor(moment().subtract(1, CS.FRESH_YEAR).startOf('week').unix())};
} else {
// Hack for at least the New page until lbryio/lbry-sdk#2591 is fixed
options.release_time = <${Math.floor(moment().startOf('minute').unix())};
}

@jessopb
Copy link
Member

jessopb commented Nov 19, 2022

Yeah, I'll release a test to make sure we can greatly reduce or eliminate these.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Existing functionality is wrong or broken
Projects
None yet
Development

No branches or pull requests

3 participants