Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat] add cue util to convert jsonschema to cue #201

Merged
merged 1 commit into from Aug 12, 2022

Conversation

humblenginr
Copy link
Member

Signed-off-by: Nithish nithishkarthik01@gmail.com

Description

This PR fixes #

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

Signed-off-by: Nithish <nithishkarthik01@gmail.com>
Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add appropriate labels and request review.

Lint failures need attention.

Copy link
Member

@Abhishek-kumar09 Abhishek-kumar09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lint failures are not subject to this PR's change. So approving it. Creating a new issue to adress the lint issues.

@leecalcote
Copy link
Member

@Abhishek-kumar09 ok, sounds good.

@Abhishek-kumar09 Abhishek-kumar09 merged commit adbb135 into master Aug 12, 2022
@Abhishek-kumar09 Abhishek-kumar09 deleted the nithish/feat/utils_cue branch August 12, 2022 18:24
@leecalcote
Copy link
Member

Hopefully, we can get @sudo-NithishKarthik into a habit of returning to his PRs for follow up. 🤞 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants