Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance notification centre with better event handling #91

Merged
merged 5 commits into from Aug 26, 2022

Conversation

Revolyssup
Copy link
Contributor

@Revolyssup Revolyssup commented Aug 21, 2022

Signed-off-by: ashish ashishjaitiwari15112000@gmail.com

Description

This PR

  1. Ensures that, in case multiple clients are connected to single Meshery instance then all events on that Meshery instance are forwarded to all connected clients.
  2. Removes a redundant global channel.

Notes for Reviewers
This is a breaking change and appropriate changes would be needed in adapters.

Signed commits

  • Yes, I signed my commits.

Signed-off-by: ashish <ashishjaitiwari15112000@gmail.com>
@Revolyssup
Copy link
Contributor Author

@MUzairS15 We will start our discussion from here.

@Revolyssup Revolyssup added the pr/draft WIP/Draft pull request label Aug 21, 2022
Signed-off-by: ashish <ashishjaitiwari15112000@gmail.com>
Signed-off-by: ashish <ashishjaitiwari15112000@gmail.com>
Signed-off-by: ashish <ashishjaitiwari15112000@gmail.com>
Signed-off-by: ashish <ashishjaitiwari15112000@gmail.com>
@Revolyssup Revolyssup merged commit 7f8bd73 into meshery:master Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr/draft WIP/Draft pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant