Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle comment options in string? #147

Open
cykerway opened this issue Aug 3, 2018 · 0 comments
Open

Handle comment options in string? #147

cykerway opened this issue Aug 3, 2018 · 0 comments

Comments

@cykerway
Copy link

cykerway commented Aug 3, 2018

def comment_options

This function currently expects symbols. However, Jekyll (a popular static site generator) uses a YAML-based config where config values are basically strings. The popular Jekyll assets plugin jekyll-assets takes those strings and directly pass them to uglifier, which is not uglifier expects. So there is some mismatch here.

I already opened an issue for jekyll-assets (here). However, I'm not sure if it's possible for uglifier to relax a bit and to detect and handle strings. Even though I believe it's downstream project responsibility to fix such incompatibility, a help from upstream may make things easier. If you wish you may click that issue link to see where exactly goes wrong. Hope you guys have some coordination.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant