added test for mssql LoginAck #1890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walf443
commented
Jun 4, 2022
| @@ -4,6 +4,7 @@ use crate::error::Error; | |||
| use crate::mssql::io::MssqlBufExt; | |||
| use crate::mssql::protocol::pre_login::Version; | |||
|
|
|||
| #[allow(dead_code)] | |||
There was a problem hiding this comment.
This is for CI warnings reduction.
sqlx-core/src/mssql/protocol/login_ack.rs#L9
field is never read: `interface`
This was referenced Jun 4, 2022
walf443
force-pushed
the
test_mssql_login_ack
branch
from
5c15ec8
to
9b15b6d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added test similar to https://github.com/launchbadge/sqlx/blob/master/sqlx-core/src/mssql/protocol/pre_login.rs#L294