Fix migration checksum comparison during migrate info
#1888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mdtusz looks like you need to run |
mdtusz
force-pushed
the
fix-info-checksum-mismatch
branch
from
07865b2
to
53276c7
Compare
|
Whoops was working on a different computer and didn't have it set up to run automatically. Should be all good to go now! |
When running `sqlx migrate info`, the applied migrations checksums are compared against the checksums of the local migration files. While the checksums of applied migrations are stored correctly in the database as sha384sum values, the `migrate info` command was incorrectly comparing these against the checksums of down-migrations in cases where reversible migrations are being used (e.g. when migrations end in `.up.sql` and `.down.sql`). This fixes the issue by skipping over any migrations with the `MigrationType::ReversibleDown` type, using the same idiom as is used when running migrations (with `migrate run`). Issue introduced in launchbadge#1680 Partially resolves launchbadge#1158
mdtusz
force-pushed
the
fix-info-checksum-mismatch
branch
from
53276c7
to
94b3375
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running
sqlx migrate info, the applied migrations checksums arecompared against the checksums of the local migration files. While the
checksums of applied migrations are stored correctly in the database as
sha384sum values, the
migrate infocommand was incorrectly comparingthese against the checksums of down-migrations in cases where reversible
migrations are being used (e.g. when migrations end in
.up.sqland.down.sql).This fixes the issue by skipping over any migrations with the
MigrationType::ReversibleDowntype, using the same idiom as is usedwhen running migrations (with
migrate run).Issue introduced in #1680
Partially resolves #1158