Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move server_version_num from trait to impl #1384

Merged
merged 3 commits into from Apr 14, 2022

Conversation

AtkinsChang
Copy link
Contributor

@AtkinsChang AtkinsChang commented Aug 17, 2021

No description provided.

@abonander
Copy link
Collaborator

Renaming a trait is a breaking change and so will have to wait until 0.6.0, which we'll be working on over the next few weeks.

@abonander
Copy link
Collaborator

abonander commented Aug 17, 2021

Actually, looking at this now, I don't really see a reason why it should be a trait and not just an inherent method on PgConnection.

PoolConnection<Postgres> dereferences to PgConnection so calling .server_version_num() on it should work with just the impl for PgConnection.

@AtkinsChang AtkinsChang changed the title Rename PgConnectionInfo to ConnectionExt Deprecate PgConnectionInfo Aug 18, 2021
@AtkinsChang
Copy link
Contributor Author

you are right, I mark this trait deprecated

Ohh, it has been released 😢

@abonander
Copy link
Collaborator

Oh yeah sorry, my mistake. I didn't realize that we hadn't actually put out a release with this trait definition in it yet.

Don't worry about marking it deprecated, we're now going to start preparing the 0.6.0 release so you can just convert the trait to a simple inherent method on PgConnection.

…Info` to impl

Signed-off-by: Atkins Chang <atkinschang@gmail.com>
@AtkinsChang AtkinsChang changed the title Deprecate PgConnectionInfo Move server_version_num from trait to impl Aug 18, 2021
@abonander abonander added this to the 0.6.0 milestone Sep 10, 2021
@abonander abonander merged commit 17760d0 into launchbadge:master Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants