Add handling for SPIR-V target #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We haven't been able to pull in fixes from rustc master for a while. I don't expect any update to rustc any time soon. |
|
If you want to work on the sync that would be super valuable, I think! We can also review this PR directly |
Manishearth
approved these changes
Mar 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're trying to use compiletest in
rust-gpu, and we ran into an issue where errors fromspirv-valinclude the binary file name with a file extension being platform dependent. This change fixes that. I've already upstreamed this changerust-lang/rust, but it seems the codebase inrusthas changed quite a bit that I couldn't easily updatecompiletest-rsto the latestmaster.I don't know if it's preferable to just port this one change or wait till the next update to
master. I could share my in progress branch of of updatingcompiletest, it compiles but it's failing the tests, something about how things get output changed that I didn't figure out yet. I'd happy to work on it, as I'd really like to get this change as usingcompiletestreally speeds up our tests, like from minutes to seconds 馃檪