Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to GitHub Actions #232

Merged
merged 2 commits into from Feb 9, 2021
Merged

Conversation

phansch
Copy link
Contributor

@phansch phansch commented Jan 26, 2021

This gets rid of both the AppVeyor build and the TravisCI build. The Travis CI build stopped triggering some time ago. Instead, we're now using GitHub Actions for both Windows and Linux builds.

Closes #227

@phansch
Copy link
Contributor Author

phansch commented Jan 26, 2021

I'm.. at a total loss why it doesn't trigger any GH Actions build? Is it because I'm only a contributor?

@Munksgaard
Copy link
Collaborator

Perhaps we need to enable it?

@Munksgaard
Copy link
Collaborator

@laumann can you make me admin, or go take a look at the actions tab in settings yourself?

@Munksgaard
Copy link
Collaborator

Munksgaard commented Jan 26, 2021

Thank you for this, by the way, @phansch 🙂

@phansch
Copy link
Contributor Author

phansch commented Jan 26, 2021

Perhaps we need to enable it?

Yup, must be a permission/setting issue; It works on my fork: phansch#1

@phansch
Copy link
Contributor Author

phansch commented Jan 26, 2021

Alright, code-wise this is ready now. What needs to be done on the repo settings side would be:

  1. Enabling GitHub Actions somewhere
  2. Removing Appveyor from the build check requirements
  3. Adding all the GitHub Actions builds to the build check requirements.
    This probably can only be done after they have all executed here once
    Maybe it's enough to close and re-open the PR to trigger the builds after 1) is done. That wouldn't require any pushes from my side.

@Munksgaard
Copy link
Collaborator

Thank you @phansch, I'll see what I can do.

@Manishearth
Copy link
Owner

IIRC for enabling github actions you just need to merge in a change to the workflows folder

@Manishearth
Copy link
Owner

@laumann I think you manually need to disable appveyor, i don't have access

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move to Github Actions
3 participants