Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic bless support #231

Merged
merged 3 commits into from Feb 10, 2021
Merged

Add basic bless support #231

merged 3 commits into from Feb 10, 2021

Conversation

phansch
Copy link
Contributor

@phansch phansch commented Jan 26, 2021

This adds basic bless support. Unfortunately without support for miri because I wasn't able to untangle it properly so far.

Should be merged after #232

@phansch phansch marked this pull request as ready for review January 30, 2021 17:04
@phansch
Copy link
Contributor Author

phansch commented Jan 31, 2021

So, the second commit adds a new testsuite as well. I think it's an improvement over the current one because it allows to quickly add new tests for different compiletest configurations. In this case for the bless config.
If we wanted to test bless support the old way, we would have to create a second test-project. The same for any other configuration.

It's a simplified version of cargo-test-support. If we ever unify both compiletest variants, it should be possible to keep that testsuite to avoid unexpected bugs.

@phansch
Copy link
Contributor Author

phansch commented Feb 9, 2021

triggering a new build

@phansch phansch closed this Feb 9, 2021
@phansch phansch reopened this Feb 9, 2021
@phansch
Copy link
Contributor Author

phansch commented Feb 9, 2021

Looks like the GitHub API is having a bad moment:

Warning: Failed to download action 'api.github.com/repos/actions/checkout/zipball/5a4ac9002d0be2fb38bd78e4b4dbde5606d7042f'. Error: Response status code does not indicate success: 500 (Internal Server Error).

https://www.githubstatus.com/incidents/5qdkkyg958vy

@Munksgaard
Copy link
Collaborator

Not quite sure what's going on here. Any guess @phansch ?

@Manishearth
Copy link
Owner

The nightly build is failing

error[E0560]: struct `TestOpts` has no field named `filter`
   --> src/lib.rs:114:9
    |
114 |         filter: config.filter.clone(),
    |         ^^^^^^ help: a field with a similar name exists: `filters`

@phansch
Copy link
Contributor Author

phansch commented Feb 10, 2021

Odd, I can't reproduce the error above locally, let's see if a rebase fixes it. nevermind, can reproduce it now

@phansch
Copy link
Contributor Author

phansch commented Feb 10, 2021

This is due to rust-lang/rust#81356, I'll try and see if I can get it upstreamed into the tester crate later today. Otherwise, we'll need to use filters only if the rustc feature is enabled.

This is a breaking change and allows for setting multiple filters at
once.
@Munksgaard Munksgaard merged commit 5fd13ff into Manishearth:master Feb 10, 2021
@phansch phansch deleted the bless branch February 10, 2021 14:14
@phansch
Copy link
Contributor Author

phansch commented Feb 10, 2021

@Munksgaard Thank you for the quick merge! Do you think it would be possible to release a 0.6 version as well?

@Munksgaard
Copy link
Collaborator

Yes, I'll do that when the CI for #225 passes :)

@Munksgaard
Copy link
Collaborator

Done!

@Munksgaard Munksgaard mentioned this pull request Mar 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants