Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.x] Vite #228

Merged
merged 1 commit into from Jul 18, 2022
Merged

[4.x] Vite #228

merged 1 commit into from Jul 18, 2022

Conversation

jessarcher
Copy link
Member

@jessarcher jessarcher commented Jul 1, 2022

This adds Vite support to laravel/ui. It also updates Vue to version 3, but maintains the options API in the example component.

Note that I have targetted master as the current 3.x version supports Laravel 8.x, while this PR will only support new Laravel 9 applications. It doesn't look like master is currently up to date with the 3.x branch.

Comment on lines -44 to +48
$this->{$this->argument('type')}();

if ($this->option('auth')) {
$this->call('ui:auth');
}

$this->{$this->argument('type')}();
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that the order is changed here because the React preset needs to change a file provided by the auth command.

@jessarcher jessarcher marked this pull request as ready for review July 18, 2022 05:21
@taylorotwell taylorotwell merged commit b73483d into master Jul 18, 2022
@taylorotwell taylorotwell deleted the vite branch July 18, 2022 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants