Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slack does not accept app directory submissions using the legacy identity.avatar,identity.basic, identity.email and identity.team scopes #702

Closed
maartenpaauw opened this issue May 1, 2024 · 4 comments

Comments

@maartenpaauw
Copy link
Contributor

Socialite Version

5.13.2

Laravel Version

11.2.0

PHP Version

8.3

Database Driver & Version

MySQL 8

Description

The Slack provider requests the scopes identity.basic, identity.email, identity.team and identity.avatar, which are marked as outdated. This means developers cannot register new Slack applications, because the following automated feedback is provided, which blocks the developer for submitting their new application to the Slack app directory.

Outdated scopes

Slack suggests to use OpenID instead.

This scope is part of an outdated approach to Sign in with Slack.
Apps using the Legacy Sign in with Slack protocol can no longer be created, and existing apps using this scope cannot be added to the App directory. We recommend using the modern Sign in with Slack protocol instead.

See https://api.slack.com/authentication/sign-in-with-slack for more information.

Steps To Reproduce

Submit an app to the Slack app directory using the scopes identity.avatar,identity.basic, identity.email and identity.team and see the error message.

@maartenpaauw maartenpaauw changed the title Slack does not accept application submissions using the legacy identity.avatar,identity.basic, identity.email and identity.team scopes Slack does not accept app directory submissions using the legacy identity.avatar,identity.basic, identity.email and identity.team scopes May 1, 2024
@maartenpaauw
Copy link
Contributor Author

I think a similar solution as the LinkedIn OpenID provider needs to be added?

#662

@maartenpaauw
Copy link
Contributor Author

I've managed to create an open id provider implementation. I'll cleanup the code a bit and open up a pull request later this week.

@driesvints
Copy link
Member

Thanks @maartenpaauw. It indeed seems we need a similar solution like the LinkedIn one if we're gonna do this on the current major release. We'd love to have a PR for this!

Copy link

github-actions bot commented May 3, 2024

Thank you for reporting this issue!

As Laravel is an open source project, we rely on the community to help us diagnose and fix issues as it is not possible to research and fix every issue reported to us via GitHub.

If possible, please make a pull request fixing the issue you have described, along with corresponding tests. All pull requests are promptly reviewed by the Laravel team.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants