From de118c8cb843f89233d92d85ef6ac10678ca9094 Mon Sep 17 00:00:00 2001 From: Cosmin Ardeleanu Date: Thu, 8 Dec 2022 21:24:48 +0200 Subject: [PATCH 1/2] Return 500 http error, instead of 200 When dotenv fails, the response on http is always 200. Because of 200 response, alerts might not be triggered, and data will be cached :( --- src/Illuminate/Foundation/Bootstrap/LoadEnvironmentVariables.php | 1 + 1 file changed, 1 insertion(+) diff --git a/src/Illuminate/Foundation/Bootstrap/LoadEnvironmentVariables.php b/src/Illuminate/Foundation/Bootstrap/LoadEnvironmentVariables.php index 64f32ebf41b6..4e13b450b5b2 100644 --- a/src/Illuminate/Foundation/Bootstrap/LoadEnvironmentVariables.php +++ b/src/Illuminate/Foundation/Bootstrap/LoadEnvironmentVariables.php @@ -103,6 +103,7 @@ protected function writeErrorAndDie(InvalidFileException $e) $output->writeln('The environment file is invalid!'); $output->writeln($e->getMessage()); + http_response_code(500); exit(1); } } From 7f271d1c8c3c7e13ec5e01fff66a0299e959c043 Mon Sep 17 00:00:00 2001 From: Taylor Otwell Date: Fri, 9 Dec 2022 10:43:58 -0600 Subject: [PATCH 2/2] Update LoadEnvironmentVariables.php --- src/Illuminate/Foundation/Bootstrap/LoadEnvironmentVariables.php | 1 + 1 file changed, 1 insertion(+) diff --git a/src/Illuminate/Foundation/Bootstrap/LoadEnvironmentVariables.php b/src/Illuminate/Foundation/Bootstrap/LoadEnvironmentVariables.php index 4e13b450b5b2..3f0be6c0a605 100644 --- a/src/Illuminate/Foundation/Bootstrap/LoadEnvironmentVariables.php +++ b/src/Illuminate/Foundation/Bootstrap/LoadEnvironmentVariables.php @@ -104,6 +104,7 @@ protected function writeErrorAndDie(InvalidFileException $e) $output->writeln($e->getMessage()); http_response_code(500); + exit(1); } }