[8.x] Add setPusher() to PusherBroadcaster::class

[vdauchy]

Hi,

This PR only add a setPusher() to the PusherBroadcaster class.

The reason is the pusher SDK instance is constructed from the configs using app_id, key and secret.

When we register the channels for broadcasting during the Application boot phase this is cached inside the BroadcastManager singleton.

In an application with many pusher configurations saved in database (ex: multitenant) those configs need to be switch in a middleware for each request.

Without a setter to change the Pusher SDK instance we need to hack using reflexion or forget the driver and then re-configure it.

Thanks :-)

[driesvints]

Why don't you just instantiate a new PusherBroadcaster instance?

[GrahamCampbell]

Yep, this seems like an antipattern to me.

[vdauchy]

Hi,

Ok let me describe the sequence:

• Application boot:

  • Broadcast::channel(...) : Here we register the channels we need, this cause the PusherBroadcaster singleton to be instanciated with as states: the channels defined + the Pusher SDK configured from the config files

• Request Handling:

  • Middleware: From the request we now know the real configuration for the Pusher SDK for that tenant and so we need to update its state in the PusherBroadcaster singleton.
  • Controller: We are now in the BroadcastController@authenticate controller (setted by Broadcast::routes()) and we need the proper Pusher SDK configuration to check the channels signature, etc...

@driesvints So my first solution was indeed to forget the driver (ie PusherBroadcaster) and re-instantiate it in the middleware with the proper config, but since it has the list of channels as state I loose them.

At the end and I really see only 2 solutions:

• Pusher switch: Pusher SDK switch in the middleware using a setter (ie this PR).
• Driver switch: Re-instantiate with the new configs but then I need to recover all other states and reinject them to the new PusherBroadcaster (trikky because Channels can be defines in different places, etc...).