From 8764270158f92244f5a0e4dac8fbb47524b86021 Mon Sep 17 00:00:00 2001
From: Dries Vints <dries@vints.io>
Date: Tue, 13 Apr 2021 14:42:28 +0200
Subject: [PATCH 1/2] Fix required_if boolean validation

---
 .../Validation/Concerns/ValidatesAttributes.php   | 15 ++++++++++++++-
 tests/Validation/ValidationValidatorTest.php      | 11 +++++++++++
 2 files changed, 25 insertions(+), 1 deletion(-)

diff --git a/src/Illuminate/Validation/Concerns/ValidatesAttributes.php b/src/Illuminate/Validation/Concerns/ValidatesAttributes.php
index 13fe1a648108..63baea92a122 100644
--- a/src/Illuminate/Validation/Concerns/ValidatesAttributes.php
+++ b/src/Illuminate/Validation/Concerns/ValidatesAttributes.php
@@ -1475,13 +1475,26 @@ protected function prepareValuesAndOther($parameters)
 
         $values = array_slice($parameters, 1);
 
-        if (is_bool($other)) {
+        if ($this->shouldConvertToBoolean($parameters[0]) || is_bool($other)) {
             $values = $this->convertValuesToBoolean($values);
         }
 
         return [$values, $other];
     }
 
+    /**
+     * Check if parameter should be converted to boolean.
+     *
+     * @param  string  $parameter
+     * @return bool
+     */
+    protected function shouldConvertToBoolean($parameter)
+    {
+        $rules = Arr::get($this->rules, $parameter, []);
+
+        return in_array('boolean', $rules);
+    }
+
     /**
      * Convert the given values to boolean if they are string "true" / "false".
      *
diff --git a/tests/Validation/ValidationValidatorTest.php b/tests/Validation/ValidationValidatorTest.php
index 4ac71213c984..2938f18e92b0 100755
--- a/tests/Validation/ValidationValidatorTest.php
+++ b/tests/Validation/ValidationValidatorTest.php
@@ -1090,6 +1090,17 @@ public function testRequiredIf()
         $v = new Validator($trans, ['first' => 'dayle', 'last' => ''], ['last' => 'RequiredIf:first,taylor,dayle']);
         $this->assertFalse($v->passes());
         $this->assertSame('The last field is required when first is dayle.', $v->messages()->first('last'));
+
+        $trans = $this->getIlluminateArrayTranslator();
+        $trans->addLines(['validation.required_if' => 'The :attribute field is required when :other is :value.'], 'en');
+        $v = new Validator($trans, ['foo' => 0], [
+            'foo' => 'required|boolean',
+            'bar' => 'required_if:foo,true',
+            'baz' => 'required_if:foo,false',
+        ]);
+        $this->assertTrue($v->fails());
+        $this->assertCount(1, $v->messages());
+        $this->assertSame('The baz field is required when foo is 0.', $v->messages()->first('baz'));
     }
 
     public function testRequiredUnless()

From 9ce74137bf13fde4c0e3bdd6704ba30656fcb879 Mon Sep 17 00:00:00 2001
From: Taylor Otwell <taylor@laravel.com>
Date: Tue, 13 Apr 2021 08:01:03 -0500
Subject: [PATCH 2/2] Update ValidatesAttributes.php

---
 src/Illuminate/Validation/Concerns/ValidatesAttributes.php | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/src/Illuminate/Validation/Concerns/ValidatesAttributes.php b/src/Illuminate/Validation/Concerns/ValidatesAttributes.php
index 63baea92a122..68b38aa8491c 100644
--- a/src/Illuminate/Validation/Concerns/ValidatesAttributes.php
+++ b/src/Illuminate/Validation/Concerns/ValidatesAttributes.php
@@ -1490,9 +1490,7 @@ protected function prepareValuesAndOther($parameters)
      */
     protected function shouldConvertToBoolean($parameter)
     {
-        $rules = Arr::get($this->rules, $parameter, []);
-
-        return in_array('boolean', $rules);
+        return in_array('boolean', Arr::get($this->rules, $parameter, []));
     }
 
     /**