[6.x] Fix mime validation for jpeg files #35518
Conversation
| $this->assertFalse($v->passes()); | ||
|
|
||
| $file2 = $this->getMockBuilder(UploadedFile::class)->setMethods(['guessExtension', 'getClientOriginalExtension'])->setConstructorArgs($uploadedFile)->getMock(); | ||
| $file2->expects($this->any())->method('guessExtension')->willReturn('jpeg'); | ||
| $file2->expects($this->any())->method('guessExtension')->willReturn('jpg'); |
There was a problem hiding this comment.
I've changed this because the recent Symfony change will always return jpg here for jpeg files.
|
I think that the same ‘problem’ happens with heic and heif files... Uploading a .heic file with this validation rule failes
But this works
|
|
I don't know anything about those file types sorry. |
yeah its ios default setting for saving photos nowadays... well my workaround works so I'll be fine :-) |
|
@it-can I had to do this to get it working And of course install the imagick on the server plus using something like |
These changes fixes a regression introduced by recent changes in Symfony and is a follow up to #35419. It makes sure that if either
mimes:jpegormimes:jpgis used that it doesn't matter wether the file is a.jpgor.jpegfile. This was the previous behaviour.I've also cleaned up some incorrect casing for the
imagerule and cleaned up the tests for themimetypesrule which were a bit out of date it seems.As a side note it would be much better if these tests were integration tests against actual files but that's out of the scope for this PR.
See #35419 (comment)