[8.x] Use --no-owner and --no-acl with pg_restore #35309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonysm
force-pushed
the
schema-load
branch
2 times, most recently
from
a1d61e2
to
aa75618
Compare
Co-authored-by: Sean Frankruyter <s.frankruyter@gmail.com>
GrahamCampbell
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed
--no-ownerfrom thedump()command, as it's a duplicate already set in thebaseDumpCommandbase commandChanged
PostgresSchemaState::load()to also use--no-ownerand--no-aclflags in thepg_restorecommand (which are also used in theschema:dump, see comment above)We were not able to run the migrate command on GitHub CI using the dump file without passing the
--no-ownerand--no-aclflags, as CI had a different DB user. The Heroku docs - for reference - also suggest using those flags withpg_restore.Co-authored-by: @funkymonk91