[7.x] Add php 8 support for Illuminate Testing 7.x #35045
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was trying to change the Lumen Framework 7.x
composer.json
to allow php 8, since you guys already made it compatible in Illuminate 6/7/8, but surprisingly the Illuminate Testing package has not been updated to allow php 8. Was that on purpose?Looks like a mistake to me since it is php 8 compatible in 8.x and I found no comments on that in related php 8 PR’s. If it is intentionally, you may close this PR :)