Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] Add php 8 support for Illuminate Testing 7.x #35045

Merged
merged 1 commit into from Oct 31, 2020

Conversation

chris-doehring
Copy link
Contributor

I was trying to change the Lumen Framework 7.x composer.json to allow php 8, since you guys already made it compatible in Illuminate 6/7/8, but surprisingly the Illuminate Testing package has not been updated to allow php 8. Was that on purpose?

Looks like a mistake to me since it is php 8 compatible in 8.x and I found no comments on that in related php 8 PR’s. If it is intentionally, you may close this PR :)

@GrahamCampbell
Copy link
Member

Oh, whoops! Looks like I missed this.

@taylorotwell taylorotwell merged commit f9c6488 into laravel:7.x Oct 31, 2020
@chris-doehring chris-doehring deleted the feature/7.x-testing-php8 branch October 31, 2020 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants