Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.x] Support Collection#countBy($key) #33852

Merged
merged 1 commit into from Aug 13, 2020
Merged

[7.x] Support Collection#countBy($key) #33852

merged 1 commit into from Aug 13, 2020
+17 −5

Conversation

JosephSilber
Copy link
Member

@JosephSilber JosephSilber commented Aug 13, 2020 •
edited

#33801 broke the usage of the collection's countBy method when passed a key as a string.

There was obviously no test for it.

This PR fixes it and adds the relevant test.

Closes #33847.

@taylorotwell taylorotwell merged commit 5682bdb into laravel:7.x Aug 13, 2020
@JosephSilber JosephSilber deleted the fix/count-by branch August 17, 2020 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@driesvints driesvints driesvints approved these changes

@GrahamCampbell GrahamCampbell GrahamCampbell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

countBy method fails if the field name is passed as a string
4 participants
@JosephSilber @driesvints @GrahamCampbell @taylorotwell