[6.x] Utilize Symfony’s PSR Factory #31018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 3, 2020 10:42
- replace DiactorosFactory with Symfony’s PSR Factory and recommended implementaiton - replace Diactoros Resposne with Nyholm’s Response per Symfony docs recommendation
GrahamCampbell
changed the title
|
Thanks for the PR. Please update the suggest blocks in the composer.json file. |
|
(in both composer.json files) |
added 2 commits
January 3, 2020 11:20
- updated routing composer on psr-http-bridge language inline with base composer file
|
FYI - Updated composer files |
GrahamCampbell
changed the title
GrahamCampbell
requested changes
Jan 3, 2020
GrahamCampbell
requested changes
Jan 3, 2020
|
Thanks for this. I've left some more comments. :) |
GrahamCampbell
requested changes
Jan 4, 2020
| if (class_exists(ZendPsrResponse::class)) { | ||
| return new ZendPsrResponse; | ||
| } | ||
|
|
||
| throw new Exception('Unable to resolve PSR response. Please install nyholm/psr7 or laminas/laminas-diactoros.'); |
There was a problem hiding this comment.
Since we're not actually supporting zendframework/zend-diactoros as per the previous discussion, and the zend stuff is now deprecated, maybe we should only recommend nyholm/psr7 here?
There was a problem hiding this comment.
So, we'll have:
Unable to resolve PSR response. Please install nyholm/psr7.
| if (class_exists(DiactorosFactory::class)) { | ||
| return (new DiactorosFactory)->createRequest($app->make('request')); | ||
| } | ||
|
|
||
| throw new Exception('Unable to resolve PSR request. Please install nyholm/psr7 or laminas/laminas-diactoros.'); |
There was a problem hiding this comment.
We should probably replace this message with:
Unable to resolve PSR request. Please install symfony/psr-http-message-bridge.
There was a problem hiding this comment.
Probably should be both since that Psr17Factory comes from the nyholm package?
Unable to resolve PSR request. Please install symfony/psr-http-message-bridge and nyholm/psr7.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #31017.