[11.x] Fix the error with the prefix in non-cached routes #51176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laravel#50239 Fix：The getPrefix() method of the Illuminate\Routing\Route returns different values for non-cached and cached routes: /{locale} - the return value of the getPrefix() method for a non-cached route {locale} - the return value of the getPrefix() method for a cached route
|
Do we have a way to write a test for this? |
Thank you for your replay, I don't have a better testing method. I observed these Route models by traversing them and found that when their Prefix property is initialized, the first initialization of Class RouteGroup: protected static function formatPrefix($new, $old, $prependExistingPrefix = true)
{
$old = $old['prefix'] ?? '';
if ($prependExistingPrefix) {
dump("old: " . $old);
dump("original: " . (isset($new['prefix']) ? trim($old, '/').'/'.trim($new['prefix'], '/') : $old));
dump("new: " . (isset($new['prefix'])
? ($old ? trim($old, '/') . '/' . trim($new['prefix'], '/') : trim($new['prefix'], '/'))
: $old));
return isset($new['prefix'])
? ($old ? trim($old, '/') . '/' . trim($new['prefix'], '/') : trim($new['prefix'], '/'))
: $old;
}
return isset($new['prefix']) ? trim($new['prefix'], '/').'/'.trim($old, '/') : $old;
}My Routing Definition: Route::group([
'prefix' => '{locale}',
'where' => ['locale' => 'en|fr|de'],
], function () {
Route::get('/', function () {
return view('welcome');
});
});Initialize routing: Tinker Testing： $routes = app('router')->getRoutes()->get('GET');
foreach ($routes as $route) {
dump($route->getPrefix());
}
|
driesvints
changed the title
|
This seems to do the opposite of what we want. It makes non-cached routes not prefixed. TBH I'm not sure any of this is even worth fixing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes : #50239
The getPrefix() method of the Illuminate\Routing\Route returns different values for non-cached and cached routes:
/{locale} - the return value of the getPrefix() method for a non-cached route
{locale} - the return value of the getPrefix() method for a cached route
This PR fixes this issue by modifying the formatPrefix function in the RouteGroup class when initializing the route model