[9.x] Auto fix docblock changes #45275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
driesvints
commented
Dec 12, 2022
|
We have a slight problem with the script I mentioned in our internal Slack we would need to look at before merging this. |
|
I've fixed the issue in #45352 I'm happy to automate this further if it is a blocker. Wasn't sure how much it would be triggered, but now we know it is pretty frequently! Enough to be a pain. I'll try and keep an eye on the auto-commits still, as there could be some more edge-cases or introduction of new Generics that we need to manually address. |
timacdonald
approved these changes
Dec 19, 2022
|
Thanks @timacdonald! |
driesvints
force-pushed
the
auto-fix-docblocks
branch
from
c4fb35c
to
1fde5a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, builds on 9.x are failing because a PR was merged without updating docblocks. This is because of the new Facade DocBlocks job that was merged here: #45154. Because of this all new PR's will now fail.
I don't think it's feasible that we keep this linting job as people will not update these docblocks themselves. Instead we should automate this. This new PR changes the job to only run on the Laravel organization and on the latest stable branches so not on PR's. People can change code as they want and when it gets merged, this GHA will automatically update DocBlocks accordingly.
This PR removes the GHA for PR's but I think it's a good thing as contributors now will not have to worry anymore about these changes/failures.