[8.x] Remove invalid Blade compiler test #37112
Conversation
jrmajor
force-pushed
the
php81/null-param
branch
from
9267b0c to
b7680a2
Compare
|
I've updated this PR to just remove the invalid test (no point changing null to an empty string in this one, there's another test for that). |
| $files->shouldReceive('get')->once()->with(null)->andReturn('Hello World'); | ||
| $files->shouldReceive('exists')->once()->with(__DIR__)->andReturn(true); | ||
| $files->shouldReceive('put')->once()->with(__DIR__.'/'.sha1(null).'.php', 'Hello World'); | ||
| $compiler->setPath(null); |
There was a problem hiding this comment.
Please find all places in the framework that might call this will null, and fix them.
There was a problem hiding this comment.
There is at least one, in the service provider.
There was a problem hiding this comment.
There is at least one, in the service provider.
Sorry, didn't see this comment. Where exactly it is? Even using normal search, without any PhpStorm magic, I can't find it.
jrmajor
changed the title
|
I don't see any reason to remove the test at the moment? |
|
@taylorotwell This test passes |
I'm not sure what is
ViewBladeCompilerTest::testDontIncludeNullPath()meant to test, but within this testnullis passed toBladeCompiler::setPath(), which docblock says it only accepts strings. It's a setter forBladeCompiler::$pathwhich, according to docblock, also isn't nullable.framework/tests/View/ViewBladeCompilerTest.php
Line 186 in 9267b0c
Unless I'm missing something, I'll send a PR to 9.x to remove this test and revert changes inBladeCompiler. If you decide this is the desired behavior, I'll update this PR to change types in docblocks to?string.