Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] Add validation support for TeamSpeak3 URI scheme #35933

Merged
merged 1 commit into from Jan 18, 2021
Merged

[8.x] Add validation support for TeamSpeak3 URI scheme #35933

merged 1 commit into from Jan 18, 2021

Conversation

homotechsual
Copy link
Contributor

This PR adds support for ts3server URI validation to the URL validator's list of protocols. Currently links to TeamSpeak3 servers fail validation as the ts3server protocol is not validated and the teamspeak protocol does not have support in most major browsers or the TeamSpeak3 application itself.

https://gaming.stackexchange.com/questions/51926/how-can-i-directly-link-to-a-teamspeak-server-on-my-website

@GrahamCampbell GrahamCampbell changed the title Add validation support for TeamSpeak3 URI scheme [8.x] Add validation support for TeamSpeak3 URI scheme Jan 17, 2021
Copy link
Member

@GrahamCampbell GrahamCampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👎 for making any edits to this. We should keep it the same as Symfony's. You should instead PR this to Symfony.

@homotechsual
Copy link
Contributor Author

👎 for making any edits to this. We should keep it the same as Symfony's. You should instead PR this to Symfony.

PRs have been accepted to change this list previously and Symfony's Validator component takes a quite different approach to protocol validation, the accepted protocols being passed to the URL constraint rather than maintaining a hardcoded central list in the code - I'm not sure there is a comparable upstream change to make to keep this in sync.

https://github.com/symfony/validator/blob/d05d14b7909a40c9c643bae833a5d11acf8212a1/Constraints/UrlValidator.php#L69
https://github.com/symfony/validator/blob/c466058e5ace12d439a2f68446f88f28d8e5a2b1/Constraints/Url.php#L32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants