[8.x] Use View contract when rendering Blade components #35920
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now
ManagesComponents
usesIlluminate\View\View
rather thanIlluminate\Contracts\View\View
which means that components that return a different implementation of the View contract break Blade components.The only code that uses this import is:
Since
with()
andrender()
are both on the view contract, it should be completely safe to swap the implementation for the interface.