Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PhpRedis bug stopping TLS encrypted cluster connection #35368

Closed
devsi opened this issue Nov 25, 2020 · 2 comments
Closed

PhpRedis bug stopping TLS encrypted cluster connection #35368

devsi opened this issue Nov 25, 2020 · 2 comments

Comments

@devsi
Copy link

devsi commented Nov 25, 2020

  • Laravel Version: 6.20.3
  • PHP Version: 7.2.33
  • Database Driver & Version: Redis 6.x / phpredis 5.3.2

Description:

Cannot connect to Clustered Redis instance over TLS in PhpRedis 5.3.2.

This is fixed in Laravel 7+. See here, but Laravel 6 still has this problem, needs a work around for Laravel 6.x as context doesn't exist as a configuration option. As Laravel 6 supports Redis over TLS and is still supported LTS I suspect it should be fixed in 6.x too.

Redis responds with: RedisClusterException : Error processing response from Redis node!

See the phpredis issue for more context. Fix is described in the last comment.

Steps To Reproduce:

Set up a TLS connection to a clustered redis. It seems every version of phpredis has the issue, but 5.3.2 introduces a fix. Needs to be reflected in Laravel

@driesvints
Copy link
Member

I've sent in a PR for this: #35370

While technically Laravel 6 is closed for new features and the new context option in Redis wasn't supported there I believe it would be good if we did. I'm closing this already. Let's see how the PR goes.

Thanks

@devsi
Copy link
Author

devsi commented Nov 26, 2020

Ah this is amazing thanks. :) I should've made the PR myself, that was rude of me! Thanks for getting that made so quick.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants