[8.x] Fixing the new maintenance mode

[arcanedev-maroc]

• Laravel Version: 8.x
• PHP Version: 7.4.9
• Database Driver & Version: none

Description:

I can't use the new maintenance mode on my machine because it's caused by this line:

<?php
// storage/framework/maintenance.php

// Check if the application is in maintenance mode...
if (! file_exists($down = __DIR__.'/../storage/framework/down')) { // <-------------- this one
    return;
}

// The rest of the file...

The file_exists($down = __DIR__.'/../storage/framework/down') always returns false.

Steps To Reproduce:

• Disable/comment the \App\Http\Middleware\PreventRequestsDuringMaintenance middleware in Http Kernel
• Run php artisan down --render="errors::503"
• Visit the website
• You should see the maintenance page even the middleware is disabled

Related: #34085

[taylorotwell]

The down file does not live in the same directory as index.php.

[arcanedev-maroc]

@taylorotwell I'm not editing public/index.php.

This is about storage/framework/maintenance.php file which is located in the same folder as down file.

Check here: https://github.com/laravel/framework/blob/8.x/src/Illuminate/Foundation/Console/DownCommand.php#L44-L52

[arcanedev-maroc]

@taylorotwell This file is DEFINITELY not index.php: https://github.com/laravel/framework/blob/8.x/src/Illuminate/Foundation/Console/stubs/maintenance-mode.stub#L4

[arcanedev-maroc]

Hi @driesvints, can you check this PR & explain the issue to @taylorotwell ?

It seems he doesn't replies to my comments

[driesvints]

Please reply to #34085 (comment) so we can focus the discussion in one place.

[taylorotwell]

Yep, this is correct. Sorry about that.

[willrowe]

Thanks for taking a look @taylorotwell and @driesvints. This was a confusing one for sure!

[kristijorgji]

The maintenancemodeexception was better then HttpException here, also including data like availableAt.

Will that be returned back ?