Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.x] DocBlock: Grammar fix in Paginator Contract #34052

Merged
merged 1 commit into from Aug 28, 2020
Merged

[6.x] DocBlock: Grammar fix in Paginator Contract #34052

merged 1 commit into from Aug 28, 2020

Conversation

BrandonSurowiec
Copy link
Contributor

Noticed the Paginator Contract incorrectly uses "is", while the implementation correctly uses "are."

    /**
     * Determine if there is more items in the data store.
     *
     * @return bool
     */
    public function hasMorePages();

    /**
     * Determine if there are more items in the data source.
     *
     * @return bool
     */
    public function hasMorePages()
    {
        return $this->currentPage() < $this->lastPage();
    }

@driesvints driesvints merged commit b75387b into laravel:6.x Aug 28, 2020
@driesvints
Copy link
Member

Thanks!

@BrandonSurowiec BrandonSurowiec deleted the patch-3 branch August 28, 2020 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants