Unable to use faker locales with WithFaker trait

[jamesfairhurst]

• Laravel Version: 6.14.0
• PHP Version: 7.4.0
• Database Driver & Version: n/a

Description:

After recent changes to the WithFaker trait on #30992 trying to use a different locale when testing no longer works.

Also related to #30345

Steps To Reproduce:

New up a laravel, attempt to create a locale faker instance:

abstract class TestCase extends BaseTestCase
{
    use CreatesApplication, WithFaker;

    protected function setUpFaker()
    {
        $this->faker = $this->makeFaker('en_GB');

        // attempt to output locale number, always from Faker\Provider\en_US\PhoneNumber
        dd($this->faker->phoneNumber);
    }
}

[AegirLeet]

This happens because

framework/src/Illuminate/Foundation/Testing/WithFaker.php

Line 49 in 32d1ed5

return $this->app->make(Generator::class, [$locale]);

passes the locale as a parameter to make() when getting the Generator from the container, but DatabaseServiceProvider, which binds the Generator at

framework/src/Illuminate/Database/DatabaseServiceProvider.php

Lines 77 to 79 in 32d1ed5

	$this->app->singleton(FakerGenerator::class, function ($app) {
	return FakerFactory::create($app['config']->get('app.faker_locale', 'en_US'));
	});

, doesn't use that value at all .

[jamesfairhurst]

@AegirLeet yeah, personally I would be leaning to revert #30992 as the use case was quite specific and could be handled in an overridden setUpFaker.