Custom translator singleton are overriding by default translator

[elvinas21]

• Laravel Version: 6.10.0
• PHP Version: 7.2.14
• Database Driver & Version: mysql 5.7.24

Description:

After I upgraded my Laravel from v6.9.0 to v6.10.0 third party translation library stopped working.
In Laravel v6.9.0 firstly are registering Laravel native 'translator' singleton and after that it registering third party libraries singletons, but in Laravel v6.10.0 firstly are registered third party libraries singleton named 'translator' and after that it will be overridden by Laravel native 'translator' singleton.

It could be caused by this changes: #31009 @GrahamCampbell please check it. Thanks.

Steps To Reproduce:

Use one of the package which extends translations functionality and register translator singleton
I'm using this https://github.com/joedixon/laravel-translation library which takes translations from database

[driesvints]

I'm not sure how these changes break that package. We'll need some more info on this to determine what has broken.

/cc @joedixon @GrahamCampbell

[joedixon]

I'm going to try and take a look at this tonight.

[joedixon]

@elvinas21, I have a fix coming for this so I think the issue can be closed.

[crynobone]

It could be caused when 3rd party is loading the service provider as eagered while Laravel translator is deferred.

[joedixon]

Hi @elvinas21, I just pushed a fix to master. Any chance you can pull down and let me know if the issue is resolved?

Thanks,
Joe

[elvinas21]

Hi @joedixon, i will check, and let you know the results.