BuildCommand::run() does not return exit code

[CupOfTea696]

BuildCommand::run() should return the command exit code, but instead returns void. This violates the return type of the parent class.

[nunomaduro]

This actually makes the code fail?

[CupOfTea696]

Any code that expects a return value from BuildCommand::run() would fail, yes. For example, if one were to use an event dispatcher on the console application, Symfony\Component\Console\Application::doRunCommand() will generate an exception for trying to construct Symfony\Component\Console\Event\ConsoleTerminateEvent without an exit code.

[nunomaduro]

Gonna actually let @owenvoke validate this one.

[owenvoke]

This is true that the run() method should return an integer exit code. I wonder why this wasn't picked up by PhpStorm or PHPStan for me. 🤔

https://github.com/symfony/symfony/blob/665222cf4dde7da5d27931eb18a5c8b244119797/src/Symfony/Component/Console/Command/Command.php#L264

(Oh, PHPStan only displays the issue on level 2, perhaps it'd be worth trying to update the PHPStan levels in future?)

[nunomaduro]

@owenvoke Indeed.