feat: support multiple database connections #1879
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calebdw
force-pushed
the
multiple_connections
branch
2 times, most recently
from
6b5393b
to
2883e8e
Compare
calebdw
force-pushed
the
multiple_connections
branch
from
2883e8e
to
ff344f1
Compare
calebdw
force-pushed
the
multiple_connections
branch
from
ff344f1
to
1758cf8
Compare
2 tasks
calebdw
force-pushed
the
multiple_connections
branch
from
1758cf8
to
0c3dcf5
Compare
|
Hey @calebdw @canvural what's the status of this PR? I'm currently leading a project at work to bump our level from 0 to 1, by generating a baseline & removing errors from the baseline each week. I didn't realise until recently that Larastan doesn't support multiple connections. We have 17 database connections, and make heavy use of Postgres schemas, so this has become a stumbling block. For now, I've switched to @calebdw's fork to keep momentum going, but would love to see it merged in. Thanks for all the hard work y'all put in maintaining this library! |
calebdw
force-pushed
the
multiple_connections
branch
from
0c3dcf5
to
cd0ba06
Compare
|
@TaylorWilton, this PR should be ready to go, just waiting for @canvural to merge :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1577, closes #1642
Note that this depends on #1838 as it built on top of the refactoring in that branch.
Changes
This PR introduces support for multiple database connections as well as Postgres Schema (sub databases).
Breaking changes
None that should affect the user, but the existing code allowed for parsing multiple schema files for a single connection (i.e., the only connection). However, Laravel saves the schema squash files as
<connection>-schema.sql. So to able to understand which schema file belongs to what connection I rely on this naming convention to determine the connection name from the filename. In practice this means there should only be one file per connection.For example, the following files would both be parsed under the
mysqlconnection:mysql-schema.{sql,dump}mysql.{sql,dump}