Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert Statuses and ErrCodes to Enums #2

Open
scaytrase opened this issue Jan 22, 2019 · 1 comment
Open

Convert Statuses and ErrCodes to Enums #2

scaytrase opened this issue Jan 22, 2019 · 1 comment
Labels
enhancement New feature or request
Milestone
2.0

Comments

@scaytrase
Copy link
Contributor

Large amount of error codes and statuses as constants will increase class size a lot and make it support more complicated. In order to avoid it it's better to move statuses into separate enums to ease client-side comparison
@scaytrase scaytrase added this to the 2.0 milestone Jan 22, 2019
@scaytrase scaytrase added the enhancement New feature or request label Jan 22, 2019
@gomzyakov
Copy link

Realized in https://github.com/gomzyakov/payture

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
2.0
Development

No branches or pull requests
2 participants
@gomzyakov @scaytrase