Request object can't easily be proxied because new headers get overwritten by original request's headers

[weierophinney]

Originally zendframework/zendframework#6101

I have an action that proxies the current request by modifying the Uri in the original request and then sending it through Zend\Http\Client. However, the new Host header based on the Uri gets overwritten by the original Host header in the original request.

Eg:

//original uri: http://example.com/proxy-request
$request = clone $this->request;
$uri = $request->getUri();
$uri->setHost('target-site.com');
$uri->setPath('/proxy-target');

$client = new Zend\Http\Client();
$response = $client->send($request);

The request ends up being sent to http://example.com/proxy-target instead of http://target-site.com/proxy-target

The new host header gets set up in https://github.com/zendframework/zend-http/blob/master/src/Client.php#L1110

But then gets replaced with the header from the request here:
https://github.com/zendframework/zend-http/blob/master/src/Client.php#L1174

Shouldn't the new headers take precedence over the headers from the request?

---

Originally posted by @dkmuir at zendframework/zend-http#64

[weierophinney]

This package is considered feature-complete, and is now in security-only maintenance mode, following a decision by the Technical Steering Committee.
If you have a security issue, please follow our security reporting guidelines.
If you wish to take on the role of maintainer, please nominate yourself

You can continue using laminas/laminas-http safely.
Its successor will be PSR-7 in a later revision of laminas/laminas-mvc.

[dkmuir]

Thanks for the update @weierophinney. PRS-7 only covers messages. Will this new revision include PSR-18 as well?

[weierophinney]

@dkmuir No, it will not. There are plenty of PSR-18 implementations already, and we see no reason to provide one ourselves. The primary use case for laminas-http was to provide HTTP messages for the MVC; the client has not had new features in many years, and offers nowhere near the functionality you'll find in most modern PHP HTTP clients.

[dkmuir]

@weierophinney Thanks for the heads up.