Feature: allow attributes for <fieldset> wrapper #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mimmi20
force-pushed
the
feature-attributes-for-fieldset-wrapper
branch
from
7952f65
to
3ecb00d
Compare
froschdesign
reviewed
Jan 3, 2024
src/View/Helper/FormRow.php
Outdated
| $markup = sprintf( | ||
| '<fieldset><legend>%s</legend>%s</fieldset>', | ||
| '<fieldset%s><legend%s>%s</legend>%s</fieldset>', |
There was a problem hiding this comment.
The problem is that the markup (fieldset and legend) is still hard-coded. The idea was therefore to use the wrapper functionality from the FormCollection helper and extend it. This would allow the same handling between the different helpers.
The legend_attributes option which is introduced here also specifies that it is always a legend element.
There was a problem hiding this comment.
In addition, I ask myself if the handling is not too cumbersome for the user, because the same options would have to be set for each MultiCheckbox or Radio element every time. 🤔
(Related to #62 (comment))
mimmi20
force-pushed
the
feature-attributes-for-fieldset-wrapper
branch
from
5c3c106
to
4bf89ef
Compare
Signed-off-by: Thomas Müller <mimmi20@live.de>
Signed-off-by: Thomas Müller <mimmi20@live.de>
Signed-off-by: Thomas Müller <mimmi20@live.de>
Signed-off-by: Thomas Müller <mimmi20@live.de>
Reducing the complexity of view helpers
Signed-off-by: George Steel <george@net-glue.co.uk>
… exception. Signed-off-by: George Steel <george@net-glue.co.uk>
Signed-off-by: George Steel <george@net-glue.co.uk>
Signed-off-by: George Steel <george@net-glue.co.uk>
…ed the same as a string literal Signed-off-by: George Steel <george@net-glue.co.uk>
Improve type inference for FormElementManager::get()
Signed-off-by: Aleksei Khudiakov <aleksey@xerkus.pro>
Signed-off-by: George Steel <george@net-glue.co.uk>
String is the correct argument type, but it is not possible to implement in the 3.x series Signed-off-by: George Steel <george@net-glue.co.uk>
Add failing test case for integer element labels
….x_MkCXLtZO Merge release 3.19.1 into 3.20.x
Signed-off-by: Thomas Müller <mimmi20@live.de>
Signed-off-by: Thomas Müller <mimmi20@live.de>
Signed-off-by: Thomas Müller <mimmi20@live.de>
Signed-off-by: Thomas Müller <mimmi20@live.de>
Signed-off-by: Thomas Müller <mimmi20@live.de>
mimmi20
force-pushed
the
feature-attributes-for-fieldset-wrapper
branch
from
4bf89ef
to
df79f8e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With this PR Attributes will be allowed an the fieldset wrapper for radio- oder multicheckbox-Elements. This PR is related to Issue #62.