Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Zend\I18n\View\Helper\AbstractTranslatorHelper dependency #50

Open
michalbundyra opened this issue Jan 15, 2020 · 9 comments
Open

Comments

@michalbundyra
Copy link
Member

This is a follow-on from #32.

You cannot use the view helpers without requiring zend-view. This is because Zend\Form\View\Helper\AbstractHelper extends Zend\I18n\View\Helper\AbstractTranslatorHelper, which in turn extends Zend\View\Helper\AbstractHelper.

I would like to break this dependency. After a quick scan it looks like implementing the setView() / getView() / setTranslator() / getTranslator() methods in the abstract helper would do the trick. Would this be the right approach?


Originally posted by @kynx at zendframework/zend-form#41

@michalbundyra
Copy link
Member Author

Unfortunately, it won't. AbstractHelper also implements HelperInterface, which all helpers need to implement. So while you'd remove the need to extend the base helper from zend-view, you'd still have the dependency due to the interface.


Originally posted by @weierophinney at zendframework/zend-form#41 (comment)

@michalbundyra
Copy link
Member Author

Gack :|

OK, so how about moving the core functionality to Zend\Form\Helper or similar and have Zend\Form\View\Helper\* proxy the core helpers?

That should be possible without a BC break (me, eternal optimist ;) and could provide a path towards moving them over to zend-view in future (discoverability / fewer suggests, as discussed over at zendframework/zend-validator#1).


Originally posted by @kynx at zendframework/zend-form#41 (comment)

@michalbundyra
Copy link
Member Author

@kynx
II like the idea that you have exposed in zendframework/zend-form#32.
i.e having a separate package for the view helpers dependent on zend-form and zend-view.
kind regards


Originally posted by @pine3ree at zendframework/zend-form#41 (comment)

@michalbundyra
Copy link
Member Author

I'm a newbie and this just bit me for a few minutes with a 26-level stack trace. Figured it out eventually, but should zendframework/zend-i18n be a composer dependency of zendframework/zend-form so that it gets brought in, until this issue is figured out by the big brains?


Originally posted by @bitwombat at zendframework/zend-form#41 (comment)

@michalbundyra
Copy link
Member Author

@bitwombat

should zendframework/zend-i18n be a composer dependency of zendframework/zend-form so that it gets brought in

It is already there. See composer.json:

"suggest": {
    "zendframework/zend-i18n": "^2.6, required when using zend-form view helpers",
}

https://github.com/zendframework/zend-form/blob/master/composer.json#L46

Why suggest section in composer? Not everyone uses the view / output part of zend-form.


Originally posted by @froschdesign at zendframework/zend-form#41 (comment)

@michalbundyra
Copy link
Member Author

Not everyone uses the view / output part of zend-form.

Ah, got it. So I should have read the 'suggested' output from composer better.

Thanks for the reply.


Originally posted by @bitwombat at zendframework/zend-form#41 (comment)

@samsonasik
Copy link
Member

I am closing it. As stated, there is i18n component in suggest in composer.json

@froschdesign
Copy link
Member

@samsonasik
Please have a look at the original description of this issue report because the problem is not the Composer configuration.

@samsonasik
Copy link
Member

@froschdesign ok, I re-open it.

@samsonasik samsonasik reopened this Aug 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants