Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reintroduce tests with external services #75

Open
heiglandreas opened this issue Nov 22, 2023 · 0 comments
Open

Reintroduce tests with external services #75

heiglandreas opened this issue Nov 22, 2023 · 0 comments
Labels
Bug Something isn't working

Comments

@heiglandreas
Copy link
Contributor

Bug Report

Q A
Version(s) 1.25.x

Summary

Currently the test-setup uses quite some time and resources to setup all the required external services like redis, memcached and mongo but then the tests actually using these services are skipped.

I tried to add the tests during enabling PHP8.3 testing but all tests failed - not only the 8.3 ones but all.

So this is something that should be done separately.

I managed to add the tests by adding this code into the qa-job in .github/workflows/continuous-integration.yml:

    env:
      TESTS_LAMINAS_DIAGNOSTICS_MEMCACHE_ENABLED: true
      TESTS_LAMINAS_DIAGNOSTICS_MEMCACHED_ENABLED: true
      TESTS_LAMINAS_DIAGNOSTICS_MONGO_ENABLED: true
      TESTS_LAMINAS_DIAGNOSTICS_RABBITMQ_ENABLED: true
      TESTS_LAMINAS_DIAGNOSTICS_REDIS_ENABLED: true

Current behavior

All tests are failing

How to reproduce

Add the yml excerpt to the described file and let the tests run

Expected behavior

All tests green

@heiglandreas heiglandreas added the Bug Something isn't working label Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant