Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in property name in UploadedFileTest::setUp() #92

Merged
merged 1 commit into from Jun 10, 2022

Conversation

TimWolla
Copy link
Contributor

Q A
Documentation no
Bugfix yes
BC Break no
New Feature no
RFC no
QA no

Description

This fixes a deprecation warning in PHP 8.2:

Deprecated: Creation of dynamic property LaminasTest\Diactoros\UploadedFileTest::$tmpfile is deprecated in /pwd/test/UploadedFileTest.php on line 39

This fixes a deprecation warning in PHP 8.2:

> Deprecated: Creation of dynamic property LaminasTest\Diactoros\UploadedFileTest::$tmpfile is deprecated in /pwd/test/UploadedFileTest.php on line 39

Signed-off-by: Tim Düsterhus <duesterhus@woltlab.com>
@Ocramius Ocramius added the Bug Something isn't working label Jun 10, 2022
@Ocramius Ocramius added this to the 2.11.1 milestone Jun 10, 2022
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'll move it to the next minor release, since it only affects tests. Thanks @TimWolla!

@Ocramius Ocramius modified the milestones: 2.11.1, 2.12.0 Jun 10, 2022
@Ocramius Ocramius changed the base branch from 2.11.x to 2.12.x June 10, 2022 12:34
@Ocramius Ocramius self-assigned this Jun 10, 2022
@Ocramius Ocramius changed the title Fix typo in property name in UploadedFileTest::setUp() Fix typo in property name in UploadedFileTest::setUp() Jun 10, 2022
@Ocramius Ocramius merged commit 2b88060 into laminas:2.12.x Jun 10, 2022
@TimWolla TimWolla deleted the uploaded-file-test branch June 10, 2022 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants