Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for Renovate with reusable workflows #80

Merged
merged 10 commits into from Mar 29, 2022
Merged

Prepare for Renovate with reusable workflows #80

merged 10 commits into from Mar 29, 2022

Conversation

ghostwriter
Copy link
Contributor

Q A
QA yes

Description

Adding Renovate to Laminas, Mezzio repositories. https://gist.github.com/weierophinney/49ca8ae2b916d898dd3d4162b26ff41b

  • Configure minimum supported PHP version
  • Update composer dependencies
  • Update to reusable Continuous Integration workflow
  • Update to reusable Automatic Releases workflow

Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
@Ocramius Ocramius added this to the 2.9.0 milestone Feb 21, 2022
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requires rolling back to a much smaller composer.lock change (just hash change)

ghostwriter and others added 6 commits February 21, 2022 22:15
Status change of HTTP experiments to Historic: https://datatracker.ietf.org/doc/status-change-http-experiments-to-historic/

Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Resolves the majority of issues flagged by Psalm.
The majority revolve around Psalm thinking a lowercase-string cannot be used for a non-empty-string, even when checks for non-empty strings are present.

Signed-off-by: Matthew Weier O'Phinney <matthew@weierophinney.net>
Long lines need to be ignored

Signed-off-by: Matthew Weier O'Phinney <matthew@weierophinney.net>
@weierophinney
Copy link
Member

The failing issue for Psalm... I cannot reproduce locally, so I cannot add it to the psalm baseline. Basically, it's raising an error because of this line in Stream.php:

        if (PHP_VERSION_ID >= 80000 && $resource instanceof \GdImage) {

GdImage was one of the resource pseudo-classes introduced in PHP 8.0, and instanceof checks do not need for the class to exist for the check to run. 😠

Signed-off-by: Matthew Weier O'Phinney <matthew@weierophinney.net>
@weierophinney weierophinney merged commit 954e2dc into laminas:2.9.x Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants