-
-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ServerRequestFactory #23
Comments
And for the host is must be required!
Originally posted by @easy-system at zendframework/zend-diactoros#158 (comment) |
Ok. Im delete this from public. Originally posted by @easy-system at zendframework/zend-diactoros#158 (comment) |
No longer relevant. |
This all works fine. Great.
But why all the logic is concentrated in one place?
Moreover, there is a class of Server.
I think it would be better to make a directory of the factories.
Firstly, it allows to separate each logic element in its factory.
Secondly, because I can always get in the code of the original values.
For example, Zend\Diactoros\Factory\HttpProtocolFactory:
All this is true for the request method, headers, Uri, uploaded files etc
Originally posted by @easy-system at zendframework/zend-diactoros#158
The text was updated successfully, but these errors were encountered: