Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use composer/semver internally to verify PHP version compatibility #87

Open
boesing opened this issue Apr 6, 2022 · 1 comment · May be fixed by #119
Open

Use composer/semver internally to verify PHP version compatibility #87

boesing opened this issue Apr 6, 2022 · 1 comment · May be fixed by #119
Labels
Enhancement RFC Request for Comment; proposal for major new feature or changes.

Comments

@boesing
Copy link
Member

boesing commented Apr 6, 2022

Feature Request

Q A
New Feature yes
RFC yes
BC Break no

Summary

As of now, we are using some semver javascript library. Since that actually does not align with all the "features" of composer, we might want to create a little PHAR which uses composer/semver under the hood to simply exit with 0 if PHP version is supported by the constraint or 1 if not.

Adding some kind of child_process to our matrix javascript node binary and we can run that PHAR from within JS for a more accurate version detection.

This would also fix #86

Thoughts?

@boesing boesing added Enhancement RFC Request for Comment; proposal for major new feature or changes. labels Apr 6, 2022
@boesing
Copy link
Member Author

boesing commented Aug 10, 2022

I've created https://github.com/boesing/composer-semver-docker
We can copy the executable from that container to /usr/local/bin so it can be used over the npm semver version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement RFC Request for Comment; proposal for major new feature or changes.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant