Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid composer.json isn't handled gracefully #289

Open
gsteel opened this issue Feb 5, 2024 · 1 comment
Open

Invalid composer.json isn't handled gracefully #289

gsteel opened this issue Feb 5, 2024 · 1 comment
Labels
Bug Something isn't working

Comments

@gsteel
Copy link
Member

gsteel commented Feb 5, 2024

Bug Report

This was first discovered in mezzio/mezzio-swoole#128

Summary

Matrix fails with unintelligible error when composer.json is invalid.

Expected behavior

Matrix generation should fail with an error message such as 'Cannot generate matrix. Invalid composer.json detected'

@gsteel gsteel added the Bug Something isn't working label Feb 5, 2024
@boesing
Copy link
Member

boesing commented Feb 7, 2024

Before composer.json is parsed, we use JSON schema to validate.
Guess we just have to add some error handling around that to catch invalid JSON files in general.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants