Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add in composer-require-checker as a globally installed tool #131

Open
internalsystemerror opened this issue Sep 13, 2022 · 5 comments
Open

Comments

@internalsystemerror
Copy link
Member

Feature Request

Q A
New Feature yes
RFC no
BC Break no

Summary

composer-require-checker is a useful tool for ensuring that composer.json contains all the necessary required packages. It is advised to be used as a standalone tool, or as globally installed, not as a development dependency.

Ideally this should be installed into this action as a PHP tool, however this is dependent on the resolution of #119.

@boesing
Copy link
Member

boesing commented Sep 14, 2022

we first should see that we merge the matrix container and CI container into one project so we have aligned releases.
Then we can add the tool to the CI container while providing the job via the matrix container.

I would not expect that we need to run composer require --global for that. If we want to have this installed for every CI run, we can add it to /usr/local/bin and use it.

Not sure why we need anything from #119, can you elaborate?

@internalsystemerror
Copy link
Member Author

internalsystemerror commented Sep 14, 2022

Because it's a PHP tool requiring PHP and the matrix runs in JS was my thinking, but I guess the JS just needs to set up a job to run like PHPUnit (which I assume is already running on PHP).

@boesing
Copy link
Member

boesing commented Sep 14, 2022

imho the matrix does not run any checks. The matrix should generate checks and thus I dont see the point why we want to execute the require checker here

@Ocramius
Copy link
Member

Indeed, matrix stays as-is, it's just the repositories that get together first

@internalsystemerror
Copy link
Member Author

I don't think we do want to do that, I was stating why I (mistakenly) thought #119 would be a blocker, but you're right we can just add it as another check once it's added to the ci container (however its installed).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants